Modify

Opened 4 years ago

Closed 4 years ago

#14209 closed defect (fixed)

UML kernel's ubd handling is broken in Linux 3.4+

Reported by: Markus Stenberg <markus.stenberg@…> Owned by: developers
Priority: normal Milestone: Chaos Calmer 15.05
Component: kernel Version: Trunk
Keywords: Cc:

Description

The command-line handling in Linux 3.4+ resets contents of the buffer which contains command line parameters for the running kernel. That is used in UML for e.g. storing filenames, and as a result, command line such as

# ./openwrt-uml-vmlinux mem=128M ubd0=/tmp/bird1.disk,./openwrt-uml-ext4.img root=98:0

won't work (it will claim it cannot find the disk image).

Something like this reverts the change done in Linux 3.4 that effectively breaks UML support:

--- pristine-linux-3.4.38/init/main.c 2013-03-28 21:12:41.000000000 +0200
+++ build-linux-3.4.38/init/main.c 2013-04-04 12:25:59.987999573 +0300
@@ -743,7 +743,7 @@

extern const struct kernel_param start_param[], stop_param[];
initcall_t *fn;


  • strcpy(static_command_line, saved_command_line);

+ /* strcpy(static_command_line, saved_command_line); */

parse_args(initcall_level_names[level],

static_command_line, start_param,
stop_param - start_param,

Attachments (0)

Change History (2)

comment:1 Changed 4 years ago by florian

Please report this specific issue to the upstream UML maintainers.

comment:2 Changed 4 years ago by cyrus

  • Resolution set to fixed
  • Status changed from new to closed

Added the patch in r38166.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.