Modify

Opened 4 years ago

Closed 4 years ago

#14206 closed defect (fixed)

uhttpd.init doesn't start https

Reported by: Josh Stone <cuviper@…> Owned by: developers
Priority: normal Milestone: Chaos Calmer 15.05
Component: packages Version: Trunk
Keywords: Cc:

Description

On the latest trunk, uhttpd is started without any -s options for https. I believe this is just an oversight from r38023, which converted everything but -s to procd_append_param style.

Attachments (0)

Change History (5)

comment:1 Changed 4 years ago by Josh Stone <cuviper@…>

Here's how I patched it directly on my router:

  • etc/init.d/uhttpd

    old new  
    112112                       append_arg "$cfg" key  "-K" 
    113113 
    114114                       for listen in $https; do 
    115                                append UHTTPD_ARGS "-s $listen" 
     115                               procd_append_param command -s "$listen" 
    116116                       done 
    117117               } 
    118118       } 

comment:2 Changed 4 years ago by hnyman <hannu.nyman@…>

The proposed change makes https to work again for uhttpd.

Patch for the package source:

--- trunk/package/network/services/uhttpd/files/uhttpd.init	(revision 38140)
+++ trunk/package/network/services/uhttpd/files/uhttpd.init	(working copy)
@@ -112,7 +112,7 @@
 			append_arg "$cfg" key  "-K"
 
 			for listen in $https; do
-				append UHTTPD_ARGS "-s $listen"
+				procd_append_param command -s "$listen"
 			done
 		}
 	}

comment:3 Changed 4 years ago by anonymous

I have mentioned this before, but my thread is disappeared.

Moreover, wifi won't UP after bootup.
Pls fix it before adding new board.

comment:4 Changed 4 years ago by Josh Stone <cuviper@…>

@anonymous - I suppose you're referring to #14195? FWIW, I have no issues with wifi on WNDR3800, so perhaps you just have a badly configured build, as suggested there. However, bug trackers are best used to focus on a single issue at a time, so let's keep this one only about uhttpd's https startup.

comment:5 Changed 4 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

fixed in r38171

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.