Modify

Opened 5 years ago

Closed 5 years ago

#13384 closed defect (fixed)

scripts/diffconfig output is broken (some content gets duplicated)

Reported by: hnyman <hannu.nyman@…> Owned by: developers
Priority: normal Milestone: Chaos Calmer 15.05
Component: toolchain Version: Trunk
Keywords: diffconfig Cc: hannu.nyman@…

Description

After today's changes to the build / config system I re-built everything from scratch. (rm -rf bin tmp build_dir staging_dir)

When comparing the output of scripts/diffconfig to the previous build, I noticed the size has grown to 14 kB from the previous 5 kB. Previous build had 152 lines in the output, now there are 399 lines.

It looks like a major part of the config gets written at least twice to the diffconfig output.

I will attach both diffconfig outputs and also the current .config

Attachments (4)

WNDR3700-trunk-r36362-2013-04-18-2136.diffconfig (13.6 KB) - added by hnyman <hannu.nyman@…> 5 years ago.
new diffconfig r36362
WNDR3700-trunk-r36354-2013-04-17-2023.diffconfig (4.6 KB) - added by hnyman <hannu.nyman@…> 5 years ago.
old diffconfig r36354
WNDR3700-trunk-r36362-2013-04-18-2136.config (131.4 KB) - added by hnyman <hannu.nyman@…> 5 years ago.
current .config
WNDR3700-trunk-r36467-2013-04-27-1728.diffconfig (8.9 KB) - added by hnyman <hannu.nyman@…> 5 years ago.
diffconfig output, duplicates removed with awk

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by hnyman <hannu.nyman@…>

new diffconfig r36362

Changed 5 years ago by hnyman <hannu.nyman@…>

old diffconfig r36354

Changed 5 years ago by hnyman <hannu.nyman@…>

current .config

comment:1 Changed 5 years ago by hnyman <hannu.nyman@…>

diffconfig output is still screwed. Some lines get duplicated.

In my own build system I have mitigated this regression by adding an awk command to my script, which script removes duplicates.

scripts/diffconfig.sh 2>/dev/null | awk '!seen[$0]++'

After that the size is about 9 kB (instead of 14 kB without awk), but still the difference to the old config system's 5 kB is rather large. I think that unnecessary "negative inclusions" get included in diffconfig output.

E.g. the following lines looks strange as I do not believe that the modules are in default config:

# CONFIG_PACKAGE_kmod-usb-serial-cp210x is not set
# CONFIG_PACKAGE_kmod-usb-serial-cypress-m8 is not set
# CONFIG_PACKAGE_l7-protocols is not set
# CONFIG_PACKAGE_lcd4linux-full is not set
# CONFIG_PACKAGE_libffmpeg-custom is not set
# CONFIG_PACKAGE_libopencdk is not set

Changed 5 years ago by hnyman <hannu.nyman@…>

diffconfig output, duplicates removed with awk

comment:2 Changed 5 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

fixed in r36522, make sure you clean scripts/config after updating

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.