Modify

Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#12680 closed enhancement (not_a_bug)

Amule 2.3.1

Reported by: d.buffa@… Owned by: developers
Priority: normal Milestone: Chaos Calmer 15.05
Component: packages Version: Trunk
Keywords: Cc:

Description

I updated the amule version in packages from 2.2.6 to 2.3.1. I have the patch, if you want to update OpenWrt trunk.

Daniele Buffa.

Attachments (2)

amule_updated.patch (5.5 KB) - added by d.buffa@… 5 years ago.
updated amule package patch
amule_updated.2.patch (5.5 KB) - added by d.buffa@… 5 years ago.
fixed package revision informations

Download all attachments as: .zip

Change History (15)

Changed 5 years ago by d.buffa@…

updated amule package patch

Changed 5 years ago by d.buffa@…

fixed package revision informations

comment:2 Changed 5 years ago by jogo

  • Resolution set to invalid
  • Status changed from new to closed

Please submit the patch to the mailing list according to SubmittingPatches. I'll close this ticket to keep trac mostly for actual bugs.

comment:3 Changed 4 years ago by anonymous

  • Resolution invalid deleted
  • Status changed from closed to reopened

Hi, this patch is still valid and tested on Raspberry and TP-LINK WDR-3600
Sorry but I'm not able to commit a patch, someone can help us?

Thanks for all work done for OpenWrt!

comment:4 follow-up: Changed 4 years ago by jogo

  • Resolution set to not_a_bug
  • Status changed from reopened to closed

The patch still needs to be submitted properly to the mailing list according to SubmittingPatches.

comment:5 Changed 4 years ago by anonymous

Sorry I forgot...
Correct PKG_MD5SUM are in this patch: https://dev.openwrt.org/attachment/ticket/12218/amule.patch

comment:6 follow-up: Changed 4 years ago by anonymous

I got always this error

Compiling DownloadQueue.cpp
In file included from DownloadQueue.h:30:0,
                 from DownloadQueue.cpp:26:
ObservableQueue.h: In instantiation of 'void CObservableQueue<ValueType>::ObserverAdded(CObservableQueue<ValueType>::ObserverType*) [with ValueType = CPartFile*; CObservableQueue<ValueType>::ObserverType = CObserver<CQueueEvent<CPartFile*> >]':
DownloadQueue.cpp:1528:32:   required from here
ObservableQueue.h:334:55: error: 'NotifyObservers' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
  NotifyObservers( EventType( EventType::STARTING ), o );
                                                       ^
ObservableQueue.h:334:55: note: declarations in dependent base 'CObservable<CQueueEvent<CPartFile*> >' are not found by unqualified lookup
ObservableQueue.h:334:55: note: use 'this->NotifyObservers' instead
ObservableQueue.h: In instantiation of 'void CObservableQueue<ValueType>::ObserverRemoved(CObservableQueue<ValueType>::ObserverType*) [with ValueType = CPartFile*; CObservableQueue<ValueType>::ObserverType = CObserver<CQueueEvent<CPartFile*> >]':
DownloadQueue.cpp:1665:1:   required from here
ObservableQueue.h:341:55: error: 'NotifyObservers' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
  NotifyObservers( EventType( EventType::STOPPING ), o );
                                                       ^
ObservableQueue.h:341:55: note: declarations in dependent base 'CObservable<CQueueEvent<CPartFile*> >' are not found by unqualified lookup
ObservableQueue.h:341:55: note: use 'this->NotifyObservers' instead
make[7]: *** [amuled-DownloadQueue.o] Error 1
make[6]: *** [all-recursive] Error 1
make[5]: *** [all-recursive] Error 1
make[4]: *** [all] Error 2

comment:7 in reply to: ↑ 6 Changed 4 years ago by anonymous

Replying to anonymous:

I got always this error

Compiling DownloadQueue.cpp
In file included from DownloadQueue.h:30:0,
                 from DownloadQueue.cpp:26:
ObservableQueue.h: In instantiation of 'void CObservableQueue<ValueType>::ObserverAdded(CObservableQueue<ValueType>::ObserverType*) [with ValueType = CPartFile*; CObservableQueue<ValueType>::ObserverType = CObserver<CQueueEvent<CPartFile*> >]':
DownloadQueue.cpp:1528:32:   required from here
ObservableQueue.h:334:55: error: 'NotifyObservers' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
  NotifyObservers( EventType( EventType::STARTING ), o );
                                                       ^
ObservableQueue.h:334:55: note: declarations in dependent base 'CObservable<CQueueEvent<CPartFile*> >' are not found by unqualified lookup
ObservableQueue.h:334:55: note: use 'this->NotifyObservers' instead
ObservableQueue.h: In instantiation of 'void CObservableQueue<ValueType>::ObserverRemoved(CObservableQueue<ValueType>::ObserverType*) [with ValueType = CPartFile*; CObservableQueue<ValueType>::ObserverType = CObserver<CQueueEvent<CPartFile*> >]':
DownloadQueue.cpp:1665:1:   required from here
ObservableQueue.h:341:55: error: 'NotifyObservers' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
  NotifyObservers( EventType( EventType::STOPPING ), o );
                                                       ^
ObservableQueue.h:341:55: note: declarations in dependent base 'CObservable<CQueueEvent<CPartFile*> >' are not found by unqualified lookup
ObservableQueue.h:341:55: note: use 'this->NotifyObservers' instead
make[7]: *** [amuled-DownloadQueue.o] Error 1
make[6]: *** [all-recursive] Error 1
make[5]: *** [all-recursive] Error 1
make[4]: *** [all] Error 2

Is a problem with trunk, no error with AA and this patch.

comment:8 Changed 4 years ago by anonymous

http://amule.forumer.com/compile-fails-on-ubuntu-13-10-64-bit-t2346301.html#p20731232

2.3.1 release doesn't compile anymore with latest gcc.
You have to use current SVN.

libreadline is not required - where did that come from?
We have a thread here somewhere about which libupnp to use (the one shipped currently also requires current SVN). But if you don't need it, just build without it.
I have built current SVN fine in this Ubuntu version.

comment:9 Changed 4 years ago by anonymous

Hi, this patch fix build also with openwrt
https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;filename=ftbfs-gcc-4.7.diff;att=1;bug=674375

Please someone is able to submit these patches with mailing lists?
Thanks

comment:10 Changed 4 years ago by anonymous

It has been fixed in the upstream sources already 2 years ago.
https://code.google.com/p/amule/source/detail?r=10772

comment:11 in reply to: ↑ 4 Changed 4 years ago by anonymous

  • Resolution not_a_bug deleted
  • Status changed from closed to reopened

Replying to jogo:

The patch still needs to be submitted properly to the mailing list according to SubmittingPatches.

http://patchwork.openwrt.org/patch/5047/

comment:12 Changed 4 years ago by nbd

  • Resolution set to not_a_bug
  • Status changed from reopened to closed

patch submissions and their status are tracked in patchwork, not in trac

comment:13 in reply to: ↑ description Changed 3 years ago by gabryels82@…

Replying to d.buffa@…:

I updated the amule version in packages from 2.2.6 to 2.3.1. I have the patch, if you want to update OpenWrt trunk.

Daniele Buffa.

Ciao Daniele,

dai repository inseriti nella mia build non riesco a trovare il pacchetto amule.
Potresti indicarmi come are per installarlo?
La mia versione è quest:

OpenWrt Chaos Calmer r42272 / LuCI Trunk (svn-r10521)

Grazie in aticipo.

Gabriele

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.