Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#12319 closed defect (fixed)

6in4.sh netifd script won't load without ip6addr

Reported by: Jérôme Poulin <jeromepoulin@…> Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Attitude Adjustment 12.09 Beta
Keywords: Cc:

Description

In package 6in4, there is a condition in which you *must* add an
ip6addr for 6in4 to come up, however, in case you've got a /48, it
might not be necessary. It would certainly be better to let the user
decide.

I also posted this patch on the ML without any answer. Maybe it is because I forgot to type [PATCH] in the subject.

Index: package/6in4/files/6in4.sh
===================================================================
--- package/6in4/files/6in4.sh  (revision 33556)
+++ package/6in4/files/6in4.sh  (working copy)
@@ -17,7 +17,7 @@
        local mtu ttl ipaddr peeraddr ip6addr tunnelid username password
        json_get_vars mtu ttl ipaddr peeraddr ip6addr tunnelid username password

-       [ -z "$ip6addr" -o -z "$peeraddr" ] && {
+       [ -z "$peeraddr" ] && {
                proto_notify_error "$cfg" "MISSING_ADDRESS"
                proto_block_restart "$cfg"
                return

Attachments (1)

6in4-no-ip6addr.patch (514 bytes) - added by Jérôme Poulin <jeromepoulin@…> 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by Jérôme Poulin <jeromepoulin@…>

comment:1 Changed 5 years ago by anonymous

Did I get it wrong? Your patch makes no sense: With the original script, if you have a peeraddr, then the ip6addr is optional and vice verso. With your patch, peeraddr is mandatory? So you condition is actually more strict.

comment:2 Changed 5 years ago by jow

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with r33761

Last edited 5 years ago by jow (previous) (diff)

comment:3 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.