Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#12245 closed defect (wontfix)

Hardcoded 'maxfail 1' option for pppd in ppp.sh

Reported by: alexey.bondarchuk@… Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: pppd Cc:

Description

Option 'maxfail 1' was hardcoded in file /package/ppp/files/ppp.sh
So now pppd ignoring setting option 'maxfail 0' in config, and not try to connect infinitely if I setup this behavior.

This problem happens after reision 31041 (diff)

Simple fix, that I tested on my DIR-300 hw B1:

Index: package/ppp/files/ppp.sh
===================================================================
--- package/ppp/files/ppp.sh	(revision 33447)
+++ package/ppp/files/ppp.sh	(working copy)
@@ -53,7 +53,7 @@
 		${keepalive:+lcp-echo-interval $interval lcp-echo-failure ${keepalive%%[, ]*}} \
 		${ipv6:++ipv6} $defaultroute \
 		${peerdns:+usepeerdns} \
-		$demand maxfail 1 \
+		$demand \
 		${username:+user "$username" password "$password"} \
 		${connect:+connect "$connect"} \
 		${disconnect:+disconnect "$disconnect"} \

Attachments (0)

Change History (2)

comment:1 Changed 5 years ago by jow

  • Resolution set to wontfix
  • Status changed from new to closed

This is deliberate. The netifd service tracks pppd and restart it if necessary.

comment:2 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.