Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#12162 closed defect (fixed)

[OpenWRT-Devel] package/kernel PATCH: Including <linux/module.h> into "drivers/net/wan/ixp4xx_hss.c"

Reported by: c.exe@… Owned by: florian
Priority: normal Milestone: Barrier Breaker 14.07
Component: kernel Version: Trunk
Keywords: Cc:

Description

Dear OpenWRT-developers,

i am trying to build OpenWRT trunk revision 33350 for the Intel XScale architecture, namely a D-Link Horstbox Professional (alias Intel IXDPG425 alias IXP4xx).

When using Kernel Version 3.3.8 the IXP4xx HSS driver module which source file is located under "drivers/net/wan/ixp4xx_hss.c" fails to build with the following error:

make[5]: Entering directory `/build/horstbox/pro/openwrt-svn/trunk/build_dir/linux-ixp4xx_generic/linux-3.3.8'
  CHK     include/linux/version.h
  CHK     include/generated/utsrelease.h
make[6]: `include/generated/mach-types.h' is up to date.
  CALL    scripts/checksyscalls.sh
  CC [M]  drivers/net/wan/ixp4xx_hss.o
drivers/net/wan/ixp4xx_hss.c:1412:20: error: expected ';', ',' or ')' before string constant
drivers/net/wan/ixp4xx_hss.c:1413:25: error: expected ';', ',' or ')' before string constant
drivers/net/wan/ixp4xx_hss.c:1414:21: error: expected ';', ',' or ')' before string constant
drivers/net/wan/ixp4xx_hss.c:1415:19: error: expected ';', ',' or ')' before string constant
make[8]: *** [drivers/net/wan/ixp4xx_hss.o] Error 1

After a short while I recognized that someone forgot to include the Kernel header file <linux/module.h> into "ixp4xx_hss.c".

I attached a patch file which includes the missing header.

Attachments (1)

horstkernel-ixp4xx_hss.patch (345 bytes) - added by c.exe@… 5 years ago.
Patch for OpenWRT Kernel version 3.3.8 to include <linux/module.h> into "drivers/net/wan/ixp4xx_hss.c"

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by c.exe@…

Patch for OpenWRT Kernel version 3.3.8 to include <linux/module.h> into "drivers/net/wan/ixp4xx_hss.c"

comment:1 Changed 5 years ago by florian

  • Owner changed from developers to florian
  • Status changed from new to assigned

comment:2 Changed 5 years ago by florian

  • Resolution set to fixed
  • Status changed from assigned to closed

Applied in r33356 and submitted for upstream inclusion, thanks!

comment:3 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.