Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#12160 closed defect (fixed)

DDNS script does not work with '/' in password

Reported by: wyldphyre Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: 10.03.1
Keywords: ddns-scripts Cc: openwrt@…

Description

The /usr/lib/ddns/dynamic_dns_updater.sh script from ddns-scripts package in Backfire (10.03.1, r29592) does not work when there is a '/' in the password. The substitution of the password will cause an error.

The error is in Line 284:

final_url=$(echo $final_url | sed s/"\[HTTPAUTH\]"/"$username${password:+:$password}"/g )

This causes (ran the script with set +x):

+ final_url=http://example:herecomestheslash%2F@dynupdate.no-ip.com/nic/update?hostname=example.no-ip.org&myip=[IP]
+ echo http://example:herecomestheslash%2F@dynupdate.no-ip.com/nic/update?hostname=example.no-ip.org&myip=[IP]
+ sed s/\[HTTPAUTH\]/example:herecomestheslash//g
sed: bad option in substitution expression

Attachments (0)

Change History (2)

comment:1 Changed 5 years ago by jow

  • Resolution set to fixed
  • Status changed from new to closed

Should be fixed with r33358

comment:2 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.