Modify

Opened 6 years ago

Last modified 4 years ago

#11890 new defect

block-mount package typo in 55_determine_extroot_sysupgrade

Reported by: Scott Shambarger <scott-openwrt@…> Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: block-mount Cc:

Description

While debugging the upgrade process for my extroot, I noticed a typo in the 55_determine_extroot_sysupgrade file, fixed with:

--- a/package/block-mount/files/55_determine_extroot_sysupgrade
+++ b/package/block-mount/files/55_determine_extroot_sysupgrade
@@ -15,7 +15,7 @@ check_set_md5sum() {
        fi
 
        local er_extroot_md5sum
-       if [ -f $md5sum_file ]; then
+       if [ -f "$er_md5sum_file" ]; then
                er_extroot_md5sum="$(cat $er_md5sum_file)"
        fi
 

Without the fix, er_extroot_md5sum is always set (and still empty when the file is missing), but cat will complain about the missing file...

Attachments (0)

Change History (1)

comment:1 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.