Modify

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#11713 closed defect (worksforme)

r32452 has no effect - kmod-leds-wndr3700-usb does not get automatically selected

Reported by: hnyman Owned by: developers
Priority: high Milestone: Barrier Breaker 14.07
Component: base system Version: Trunk
Keywords: WNDR3700 LED Cc: hannu.nyman@…

Description

r32452 supposedly changed WNDR3700 build to include kmod-leds-wndr3700-usb by default.

For some strange reason that I can't figure out, the package does not get automatically included.

It is defined at: https://dev.openwrt.org/browser/trunk/package/kernel/modules/leds.mk#L59

I noticed that ar71xx/config-3.3 explicitly deselects that module. Might that be the reason?
https://dev.openwrt.org/browser/trunk/target/linux/ar71xx/config-3.3#L151

Menuconfig does not even show that module to get selected by anything.

make menuconfig --> search with / for '3700':

 OpenWrt Attitude Adjustment (r32462) Configuration
 ──────────────────────────────────────────────────────────────────────────────────────────────
  ┌──────────────────────────────────── Search Results ─────────────────────────────────────┐
  │ Symbol: DEFAULT_kmod-leds-wndr3700-usb [=DEFAULT_kmod-leds-wndr3700-usb]                │  
  │                                                                                         │  
  │                                                                                         │  
  │ Symbol: TARGET_ar71xx_generic_WNDR3700 [=y]                                             │  
  │ Prompt: NETGEAR WNDR3700/WNDR3800/WNDRMAC                                               │  
  │   Defined at tmp/.config-target.in:2699                                                 │  
  │   Depends on: <choice> && TARGET_ar71xx_generic [=y]                                    │  
  │   Location:                                                                             │  
  │     -> Target Profile (<choice> [=y])                                                   │  
  │   Selects: DEFAULT_base-files [=y] && DEFAULT_busybox [=y] && DEFAULT_dnsmasq [=y] && D │  
  │                                                                                         │  
  │                                                                                         │  
  │ Symbol: PACKAGE_kmod-leds-wndr3700-usb [=n]                                             │  
  │ Prompt: kmod-leds-wndr3700-usb.......................... WNDR3700 USB LED support       │  
  │   Defined at tmp/.config-package.in:4008                                                │  
  │   Depends on: TARGET_ar71xx [=y]                                                        │  
  │   Location:                                                                             │  
  │     -> Kernel modules                                                                   │  
  │       -> LED modules                                                                    │  
  │                                                                                         │  
  │                                                                                         │  
  │                                                                                         │  
  │                                                                                         │  
  ├─────────────────────────────────────────────────────────────────────────────────(100%)──┤  
  │                                        < Exit >                                         │  
  └─────────────────────────────────────────────────────────────────────────────────────────┘  
 

Attachments (0)

Change History (3)

comment:1 Changed 6 years ago by nbd

  • Resolution set to worksforme
  • Status changed from new to closed

the build system currently does not automatically pick up changes to profiles unless the target is scanned again.
do this:

touch target/linux/ar71xx/Makefile
rm .config
make menuconfig

then select the WNDR3700 profile again, it will now include kmod-leds-wndr3700-usb by default

comment:2 Changed 6 years ago by hnyman <hannu.nyman@…>

Thanks. You are right. ;-)

I had already tested removing .config etc., but the need to touch the profile Makefile was new to me.

Do you know if it is only the profile Makefile, or does similar behaviour concern also other default option source files?

I run 'make dirclean' every now and then, so that should usually take care of that, I guess.

I am thinking if should I include that touch command to my buildscript just before make defconfig, in order to be able to pick up any similar changes in future. Probably overkill, as a weekly make dirclean will cause the changes to get implemented in any case.

comment:3 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.