Modify

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#11703 closed defect (worksforme)

packages/net/imspector: fix unquoted CXX specifier in Makefile

Reported by: Greg Turner <gmt@…> Owned by: blogic
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: Cc:

Description

Without the quotes, ccache compilation breaks. Patch relative to packages/.

diff --git a/net/imspector/Makefile b/net/imspector/Makefile
index 9990872..9161b56 100644
--- a/net/imspector/Makefile
+++ b/net/imspector/Makefile
@@ -54,7 +54,7 @@ define Build/Compile
            SSL_FLAGS="$(TARGET_CPPFLAGS) -DHAVE_SSL" \
            SSL_OBJS=sslstate.o \
            PREFIX="$(STAGING_DIR)/usr" \
-           CXX=$(TARGET_CXX) \
+           CXX="$(TARGET_CXX)" \
            CXXFLAGS="$(TARGET_CXXFLAGS) $(TARGET_CFLAGS) $(FPIC) $(TARGET_CPPFLAGS) \
                        -I$(ICONV_PREFIX)/include \
                        $(TARGET_LDFLAGS) -DHAVE_SSL" \

Attachments (0)

Change History (6)

comment:1 follow-up: Changed 6 years ago by jow

  • Owner changed from developers to blogic
  • Status changed from new to assigned

blogic: do we still need this quoting after introducing the ccache wrapper?

comment:2 in reply to: ↑ 1 ; follow-ups: Changed 6 years ago by Greg Turner <gmt@…>

Replying to jow:

blogic: do we still need this quoting after introducing the ccache wrapper?

I should have mentioned that I'm building against a trunk based on r30776, so if the wrapper was introduced/refined between then and now this is certainly possible.

comment:3 in reply to: ↑ 2 Changed 6 years ago by Greg Turner <gmt@…>

Replying to Greg Turner <gmt@…>:

Replying to jow:

blogic: do we still need this quoting after introducing the ccache wrapper?

this is certainly possible.

(clarification: possible that I filed a bad bug and that the quoting is not needed)

comment:4 in reply to: ↑ 2 Changed 6 years ago by Greg Turner <gmt@…>

Replying to Greg Turner <gmt@…>:

Replying to jow:

blogic: do we still need this quoting after introducing the ccache wrapper?

Confirmed, now, that quoting is not needed with the ccache wrapper -- I cherry-picked r32075 (plus reverted the quotes above), and imspector now builds like a champ.

So... this is a non-bug (unless other stuff needing quoting can legitimately wind up in TARGET_CXX, in which case, I guess it's a bug nevertheless).

comment:5 Changed 6 years ago by nbd

  • Resolution set to worksforme
  • Status changed from assigned to closed

comment:6 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.