Modify

Opened 6 years ago

Last modified 4 years ago

#11361 new defect

missing dependency in Makefiles which include nls.mk using iconv-full

Reported by: xuefer@… Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: Cc:

Description

i'm using libiconv-full. when i compile amule it failed to create executable. by checking config.log i can see it cannot find iconv lib for linking. i.e., libiconv-full dev files is not installed. it should be compile and dev-install before building amule. amule/Makefile is missing iconv as dependency, so as many other packages

# let's see how many packages uses nls.mk
~/src/openwrt $ find package feeds/packages/* -type f | xargs grep -l nls.mk |wc -l
63

# and how many packages uses ICONV_DEPENDS variable
~/src/openwrt $ find package feeds/packages/* -type f | xargs grep -l ICONV_DEPENDS |wc -l
26

and then i read nls.mk. it's strange

PKG_CONFIG_DEPENDS += CONFIG_BUILD_NLS
PKG_BUILD_DEPENDS += !BUILD_NLS:libiconv !BUILD_NLS:gettext

ICONV_DEPENDS:=+BUILD_NLS:libiconv-full

in !BUILD_NLS case, it's looks good as the dependency is added to PKG_BUILD_DEPENDS, but not with +BUILD_NLS case

Attachments (0)

Change History (1)

comment:1 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.