Modify

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#11181 closed defect (fixed)

Busybox not handling daylight saving time TZ correct

Reported by: tabacdk@… Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: base system Version: 10.03.1
Keywords: Cc:

Description

root@bob:~# cat /etc/banner 
  _______                     ________        __
 |       |.-----.-----.-----.|  |  |  |.----.|  |_
 |   -   ||  _  |  -__|     ||  |  |  ||   _||   _|
 |_______||   __|_____|__|__||________||__|  |____|
          |__| W I R E L E S S   F R E E D O M
 Backfire (10.03.1, r29592) ------------------------
  * 1/3 shot Kahlua    In a shot glass, layer Kahlua 
  * 1/3 shot Bailey's  on the bottom, then Bailey's, 
  * 1/3 shot Vodka     then Vodka.
 ---------------------------------------------------
root@bob:~# date '+%s'
1332689862
root@bob:~# TZ=C date
Sun Mar 25 15:37:55 UTC 2012
root@bob:~# TZ='CET-1CEST,M3.5.0,M10.5.0/3' date
Sun Mar 25 16:38:04 CET 2012
root@bob:~# TZ='CET-1CEST,M3.4.0,M10.5.0/3' date
Sun Mar 25 17:38:11 CEST 2012

According to http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html M3.5.0 means the fifth (or last!) Sunday (day 0) of March. I have checked this om my glibc system (Ubuntu 11.10) and appears to be so. But it is wrong on my OpenWRT busybox date

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by tabacdk@…

root@bob:~# TZ='CET-1CEST-2,M3.5.1,M10.5.0/3' date -d '2012-03-26 12:00'
Mon Mar 26 12:00:00 CEST 2012

Trying out a few things yields that the bug doesn't surface the following day. Perhaps it is related to the fact that the the month changes the following Sunday. I don't know.

Thomas

comment:2 follow-up: Changed 6 years ago by florian

comment:3 in reply to: ↑ 2 Changed 6 years ago by Thomas Ammitzboll-Bach <tabacdk@…>

Replying to florian:

It is certainly related to this bug instead: http://old.nabble.com/-PATCH--libc%3A-fix-daylight-saving-time-handling-td32630806.html

Looks like the source of the problem. Anyway: A workaround seems to be simply changing the TZ string to CET-1CEST,M3.4.0,M10.5.0/3 and change it back April 1.

--- /etc/config/system.orig	Sun Mar 25 19:18:03 2012
+++ /etc/config/system	Sun Mar 25 19:25:04 2012
@@ -2,7 +2,7 @@
 config 'system'
 	option 'hostname' 'bob'
 	option 'zonename' 'Europe/Copenhagen'
-	option 'timezone' 'CET-1CEST,M3.5.0,M10.5.0/3'
+	option 'timezone' 'CET-1CEST,M3.4.0,M10.5.0/3'
 	option 'cronloglevel' '8'
 	option 'conloglevel' '5'
 	option 'log_size' '512'

I am fine with that :-)

Thomas

comment:4 Changed 6 years ago by hnyman <hannu.nyman@…>

Looks like it has been fixed uClibc upstream for 0.9.33 that trunk uses, but not for 0.9.30.1 that Backfire 10.03 branch still uses.

http://git.uclibc.org/uClibc/commit/?h=0.9.33&id=47f3da1cf49377c25772bb54d07db55225bbb142

So trunk should work ok, but Backfire might need a manual patch if that bug is seen serious enough.

comment:5 Changed 6 years ago by Thomas Ammitzboll-Bach <tabacdk@…>

I don't know about other regions, but in EU the problem will not arise again until October 2020. I think it is a waste of good people's time to create a patch as long as the bug is known and it can be worked around.

Thomas

comment:6 Changed 6 years ago by florian

  • Resolution set to fixed
  • Status changed from new to closed

The fix has been backported in r31074 for backfire and r31073 for trunk.

comment:7 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.