fw__uci_state_del() can't delete item

[cz <chengzhicn@…>]

from /lib/firewall/core_interface.sh

fw__uci_state_del() {
        local var="$1"
        local item="$2"

        local rest=""
        local val="$(uci_get_state firewall core $var)"
        local e1; for e1 in $val; do
                local e2; for e2 in $item; do
                        [ "$e1" = "$e2" ] && e1=""
                done
                rest="${rest:+$rest${e1:+ }}$e1"
        done

        uci_toggle_state firewall core $var "$val"
}

rest is assigned but never used.
maybe it should be like

uci_toggle_state firewall core $var "$rest"

[jow]

You're absolutely right - thanks for the heads up. Fixed in r30938.

[jow]

Milestone Attitude Adjustment 12.09 deleted