Modify ↓
#11132 closed defect (fixed)
fw__uci_state_del() can't delete item
Reported by: | cz <chengzhicn@…> | Owned by: | developers |
---|---|---|---|
Priority: | low | Milestone: | Barrier Breaker 14.07 |
Component: | base system | Version: | Trunk |
Keywords: | Cc: |
Description
from /lib/firewall/core_interface.sh
fw__uci_state_del() { local var="$1" local item="$2" local rest="" local val="$(uci_get_state firewall core $var)" local e1; for e1 in $val; do local e2; for e2 in $item; do [ "$e1" = "$e2" ] && e1="" done rest="${rest:+$rest${e1:+ }}$e1" done uci_toggle_state firewall core $var "$val" }
rest is assigned but never used.
maybe it should be like
uci_toggle_state firewall core $var "$rest"
Attachments (0)
Change History (2)
comment:1 Changed 6 years ago by jow
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 4 years ago by jow
- Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07
Milestone Attitude Adjustment 12.09 deleted
Note: See
TracTickets for help on using
tickets.
You're absolutely right - thanks for the heads up. Fixed in r30938.