Modify

Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#10832 closed defect (fixed)

Compile errors when BCM47XX_BCMA option is disabled in kernel config

Reported by: kwestarz@… Owned by: hauke
Priority: normal Milestone: Barrier Breaker 14.07
Component: kernel Version: Trunk
Keywords: Cc:

Description

When BCM47XX_BCMA is disabled in kernel config, build fails on b43 driver compilation, in mac80211 makefile CONFIG_B43_BCMA is always set and 0016-brcm47xx-add-common-interface-for-sflash.patch contains unconditional references to BCMA. There can be other errors, I've given up after second one.

Attachments (1)

0999-jrr-remove-bcma.patch (1.6 KB) - added by roysjosh@… 6 years ago.
remove unconditional BCMA references

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by hauke

  • Owner changed from developers to hauke
  • Status changed from new to accepted

OpenWrt does not support all possible kernel configurations when you change something with make kernel_menuconfig it could cause some other problems. The kernel should compile regardless which option you select in kernel_menuconfig, I will work on this.

Changed 6 years ago by roysjosh@…

remove unconditional BCMA references

comment:2 Changed 6 years ago by roysjosh@…

I've been using this patch locally for a bit. Also had to disable BCMA options (and SSB GIGE) in kernel_menuconfig.

comment:3 Changed 6 years ago by roysjosh@…

Oh, and the mac80211 makefile:

diff --git a/package/mac80211/Makefile b/package/mac80211/Makefile
index 1ab9dc2..aaf3cd7 100644
--- a/package/mac80211/Makefile
+++ b/package/mac80211/Makefile
@@ -1096,11 +1096,9 @@ BUILDFLAGS:= \
 	$(if $(CONFIG_ATH_USER_REGD),-DATH_USER_REGD=1) \
 	$(if $(CONFIG_PACKAGE_B43_DEBUG),-DCONFIG_B43_DEBUG) \
 	$(if $(CONFIG_PACKAGE_B43_PIO),-DCONFIG_B43_PIO) \
-	$(if $(CONFIG_PACKAGE_B43_PIO),-DCONFIG_B43_BCMA_PIO) \
 	$(if $(CONFIG_PACKAGE_B43_PHY_N),-DCONFIG_B43_PHY_N) \
 	$(if $(CONFIG_PACKAGE_B43_PHY_HT),-DCONFIG_B43_PHY_HT) \
 	$(if $(CONFIG_PACKAGE_B43_PHY_LCN),-DCONFIG_B43_PHY_LCN) \
-	-DCONFIG_B43_BCMA -DCONFIG_B43_BCMA_EXTRA \
 	-DCONFIG_B43_SSB \
 	$(if $(CONFIG_PACKAGE_RT2X00_LIB_DEBUGFS),-DCONFIG_RT2X00_LIB_DEBUGFS) \
 	$(if $(CONFIG_PACKAGE_RT2X00_DEBUG),-DCONFIG_RT2X00_DEBUG) \
@@ -1141,11 +1139,9 @@ MAKE_OPTS:= \
 	CONFIG_B43LEGACY=$(if $(CONFIG_PACKAGE_kmod-b43legacy),m) \
 	CONFIG_B43_DEBUG=$(if $(CONFIG_PACKAGE_B43_DEBUG),y) \
 	CONFIG_B43_PIO=$(if $(CONFIG_PACKAGE_B43_PIO),y) \
-	CONFIG_B43_BCMA_PIO=$(if $(CONFIG_PACKAGE_B43_PIO),y) \
 	CONFIG_B43_PHY_N=$(if $(CONFIG_PACKAGE_B43_PHY_N),y) \
 	CONFIG_B43_PHY_HT=$(if $(CONFIG_PACKAGE_B43_PHY_HT),y) \
 	CONFIG_B43_PHY_LCN=$(if $(CONFIG_PACKAGE_B43_PHY_LCN),y) \
-	CONFIG_B43_BCMA=y \
 	CONFIG_B43_SSB=y \
 	CONFIG_ATH_COMMON=$(if $(CONFIG_PACKAGE_kmod-ath),m) \
 	CONFIG_ATH_DEBUG=$(if $(CONFIG_PACKAGE_ATH_DEBUG),y) \

comment:4 Changed 5 years ago by hauke

  • Resolution set to fixed
  • Status changed from accepted to closed

The brcm47xx target in OpenWrt should now build just with ssb or just with bcma support enabled.

comment:5 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.