Modify

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#10461 closed defect (fixed)

Hook sysupgrade_pre_upgrade is executed after processes have been killed

Reported by: Robert Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: base system Version: Trunk
Keywords: sysupgrade Cc:

Description

Since [28626], most processes get killed before the update is started. Unfortunately, this happens before the hook sysupgrade_pre_upgrade is executed. As a result, certain actions cannot be done anymore in this hook.

Example: I created a script to upload the configuration files to my server (just in case..) immediately before the update (after the *.gz file has been created) and give the user (myself) the chance to check the result and the list of saved files before confirming the update.
Both of these things fail now. First, the network connection is already down at this point (maybe because my server supports IPv6 and aiccu was killed before). And stopping at this point leaves me with a system which I can practically only restart.

All of this could be solved by moving the call to the hook in /sbin/sysupgrade a few lines up, before killing the processes.

I have check the usage of the hook on my ar71xx image:

root@router:/lib/upgrade# grep sysupgrade_pre_upgrade *
all0258n.sh:append sysupgrade_pre_upgrade platform_add_ramfs_ubootenv
mysysupgrade.sh:append sysupgrade_pre_upgrade remote_store_backup
mysysupgrade.sh:append sysupgrade_pre_upgrade confirm_the_upgrade
platform.sh:append sysupgrade_pre_upgrade disable_watchdog

platform_add_ramfs_ubootenv only seems to copy some files and disable_watchdog kills another process - should not matter for these two whether other processes were killed before or not.

Attachments (0)

Change History (2)

comment:1 Changed 6 years ago by jow

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with r29256.

comment:2 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.