Modify

Opened 6 years ago

Last modified 4 years ago

#10458 new defect

Patches for scripts/env

Reported by: Rolf Leggewie <dev.openwrt.org@…> Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: other Version: Backfire 10.03.1 RC6
Keywords: Cc:

Description

Here are three patches that I applied locally to scripts/env in backfire branch. One fixes a regression introduced in r22336. Thank you for your consideration.

Attachments (7)

0001-scripts-env-fix-indentation.patch (539 bytes) - added by Rolf Leggewie <dev.openwrt.org@…> 6 years ago.
0002-scripts-env-fix-r22336-and-move-the-asterisk-back-ou.patch (860 bytes) - added by Rolf Leggewie <dev.openwrt.org@…> 6 years ago.
0003-scripts-env-make-mv-and-cp-operations-more-robust-tr.patch (1.1 KB) - added by Rolf Leggewie <dev.openwrt.org@…> 6 years ago.
0004-scripts-env-fix-another-occurrence-of-glob-inside-pa.patch (799 bytes) - added by Rolf Leggewie <dev.openwrt.org@…> 6 years ago.
0005-scripts-env-improve-the-wording-of-the-question-when.patch (869 bytes) - added by Rolf Leggewie <dev.openwrt.org@…> 6 years ago.
0006-scripts-env-pad-the-dangerous-clear-command-with-a-r.patch (2.7 KB) - added by Rolf Leggewie <dev.openwrt.org@…> 6 years ago.
0001-scripts-env-pad-the-dangerous-clear-command-with-a-r.patch (1.9 KB) - added by Rolf Leggewie <dev.openwrt.org@…> 6 years ago.
rebased patch

Download all attachments as: .zip

Change History (13)

Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

comment:1 Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

I just found another occurrence of the same error (asterisk glob inside parentheses) that makes the clear command of this script loose all data. Here is another patch that fixes this, too.

Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

comment:2 Changed 6 years ago by nbd

I committed three of these patches to trunk (the ones that actually applied), fixing a bug in the 0003 patch, which dropped an important cp command.

please rework your last patch so that it applies against trunk, I will backport the entire updated scripts/env file to backfire afterwards.

comment:3 Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

My apologies for the delay in response. I still intend to get to this eventually.

comment:4 Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

I see that you applied #1, #3 and #5. #2 and #4 were already previously applied as r26391 but never backported to backfire (the changes are very essential). Please find a rebased #6 as attachment.

Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

rebased patch

comment:5 Changed 6 years ago by Rolf Leggewie <dev.openwrt.org@…>

It would be appreciated if authorship of the patch were to be preserved.

comment:6 Changed 4 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.