Changeset 42379

Timestamp:

2014-09-01T15:21:54+02:00 (3 years ago)

Author:

blogic

Message:

package/*: remove useless explicit set of function returncode

somebody started to set a function returncode in the validation
stuff and everybody copies it, e.g.

myfunction()
{

fire_command

return $?

}

a function automatically returns with the last returncode,
so we can safely remove the command 'return $?'. reference:

​http://tldp.org/LDP/abs/html/exit-status.html
"The last command executed in the function or script determines the exit status."

Signed-off-by: Bastian Bittorf <bittorf@…>

Backport of r42278

Location:

branches/barrier_breaker/package

Files:

• base-files/files/etc/init.d/system (modified) (1 diff)
• network/config/firewall/files/firewall.init (modified) (2 diffs)
• network/config/netifd/files/etc/init.d/network (modified) (7 diffs)
• network/services/dropbear/files/dropbear.init (modified) (1 diff)
• network/services/relayd/files/relay.init (modified) (1 diff)
• system/ubox/files/log.init (modified) (2 diffs)
• utils/busybox/files/sysntpd (modified) (1 diff)

branches/barrier_breaker/package/base-files/files/etc/init.d/system

@@ -13 +13 @@
                 'timezone:string:UTC' \
                 'zonename:string'
-
-        return $?
 }
 

branches/barrier_breaker/package/network/config/firewall/files/firewall.init

@@ -16 +16 @@
                 'dest_port:or(port, portrange)' \
                 'target:or("SNAT", "DNAT")'
-        
-        return $?
 }
 
@@ -29 +27 @@
                 'dest_port:or(port, portrange)' \
                 'target:string'
-        
-        return $?
 }
 

branches/barrier_breaker/package/network/config/netifd/files/etc/init.d/network

@@ -51 +51 @@
                 'encaps:or("llc", "vc"):llc' \
                 'payload:or("bridged", "routed"):bridged'
-
-        return $?
 }
 
@@ -65 +63 @@
                 'mtu:uinteger' \
                 'table:or(range(0,65535),string)'
-
-        return $?
 }
 
@@ -78 +74 @@
                 'mtu:uinteger' \
                 'table:or(range(0,65535),string)'
-
-        return $?
 }
 
@@ -95 +89 @@
                 'goto:range(0,65535)' \
                 'action:or("prohibit", "unreachable", "blackhole", "throw")'
-
-        return $?
 }
 
@@ -112 +104 @@
                 'goto:range(0,65535)' \
                 'action:or("prohibit", "unreachable", "blackhole", "throw")'
-
-        return $?
 }
 
@@ -123 +113 @@
                 'enable_vlan:bool' \
                 'reset:bool'
-
-        return $?
 }
 
@@ -133 +121 @@
                 'vlan:uinteger' \
                 'ports:list(ports)'
-
-        return $?
 }
 

branches/barrier_breaker/package/network/services/dropbear/files/dropbear.init

@@ -48 +48 @@
                 'SSHKeepAlive:uinteger:300' \
                 'IdleTimeout:uinteger:0'
-        return $?
 }
 

branches/barrier_breaker/package/network/services/relayd/files/relay.init

@@ -16 +16 @@
                 'forward_bcast:bool:1' \
                 'forward_dhcp:bool:1'
-
-        return $?
 }
 

branches/barrier_breaker/package/system/ubox/files/log.init

@@ -20 +20 @@
                 'log_proto:or("tcp", "udp"):udp' \
                 'log_prefix:string'
-        return $?
 }
 
@@ -28 +27 @@
                 'log_size:uinteger:0' \
                 'log_buffer_size:uinteger:0'
-        return $?
 }
 

branches/barrier_breaker/package/utils/busybox/files/sysntpd

@@ -10 +10 @@
         uci_validate_section system timeserver "${1}" \
                 'server:list(host)' 'enabled:bool:1' 'enable_server:bool:0'
-        return $?
 }