Changeset 40645


Ignore:
Timestamp:
2014-05-01T21:12:00+02:00 (4 years ago)
Author:
hauke
Message:

collectd: Fix collectd / Luci statistics breakage due to r39119 / #15010

Collectd / Luci statistics module has been broken since r39119 (in December
2013). Buildbot has not built it succesfully since then.

Bug 15010 describes the issue: https://dev.archive.openwrt.org/ticket/15010.html
Changeset 39119: https://dev.archive.openwrt.org/changeset/39119.html

The build breakage only concerns one collectd plugin, netlink, which expects
iproute2 to be compiled with "fpic" option, which was removed by r39119 in
order to make iproute2 smaller.
http://buildbot.openwrt.org:8010/broken_packages/ar71xx/collectd/compile.txt

There are two alternative fixes:

  • add fpic back to iproute2 compile options. But devs apparently

intentionally removed it to decrease size

  • alternatively, disable netlink plugin in collectd by marking it broken

It is unfortunate that the whole collectd remains uncompiled in buildbot
snapshots due to that one minor plugin. Other bugs related to this (e.g.
#15077 and #14642) were closed three weeks ago as duplicates of #15010, but I
have seen no action regarding actually fixing the issue.

So, please find attached a patch marking the netlink plugin broken.
All other collectd modules do compile. I compile-tested them with ar71xx.

Signed-off-by: hannu.nyman@…

File:
1 edited

Legend:

Unmodified
Added
Removed
  • packages/utils/collectd/Makefile

    r39925 r40645  
    280280$(eval $(call BuildPlugin,memory,physical memory usage input,memory,)) 
    281281$(eval $(call BuildPlugin,modbus,read variables through libmodbus,modbus,+PACKAGE_collectd-mod-modbus:libmodbus @BROKEN)) 
    282 $(eval $(call BuildPlugin,netlink,netlink input,netlink,+PACKAGE_collectd-mod-netlink:ip)) 
     282$(eval $(call BuildPlugin,netlink,netlink input,netlink,+PACKAGE_collectd-mod-netlink:ip @BROKEN)) 
    283283$(eval $(call BuildPlugin,network,network input/output,network)) 
    284284$(eval $(call BuildPlugin,nginx,nginx status input,nginx,+PACKAGE_collectd-mod-nginx:libcurl)) 
Note: See TracChangeset for help on using the changeset viewer.