Changeset 33321


Ignore:
Timestamp:
2012-09-05T22:08:42+02:00 (5 years ago)
Author:
juhosg
Message:

ramips: Use doubletagging to disable ramips_esw vlan by default, it seems more reliable.

Use doubletagging to disable ramips_esw vlan by default, it seems
more reliable.

Daniel Golle found an issue where sometimes (possibly only for
RT3352) the default vlan disable method (clearing en_vlan, untag,
doubletag and putting all ports into vlan 0) doesn't work and the
packets get sent out vlan-tagged with vlan 0.

Instead switch to using the doubletagging method (allow doubletagged
packets, put all ports into vlan 0 with untag enabled) by default.

Unless someone figures out a way to really globally disable vlan for
this switch, this seems like the best (most reliable) option.

I did some tests regarding maximum packet size and did not see any

difference between the two methods, both allow for slightly bigger packets
than the ramips_main.c ethernet driver (ping stops going through
above "ping -s 1472" (1514 bytes), on the switch packets are recv_good until
"ping -s 1490", or about 1532 bytes).

Signed-off-by: Tobias Diedrich <ranma+openwrt@…>

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/target/linux/ramips/files/drivers/net/ethernet/ramips/ramips_esw.c

    r33304 r33321  
    535535                        pvid       = esw->ports[i].pvid; 
    536536                } else { 
    537                         int x = esw->alt_vlan_disable ? 1 : 0; 
     537                        int x = esw->alt_vlan_disable ? 0 : 1; 
    538538                        doubletag |= x << i; 
    539539                        en_vlan   |= x << i; 
Note: See TracChangeset for help on using the changeset viewer.